Re: [PATCH] bcd: limit bin2bcd input value to lie between 0-99

[Andrew Morton]

On Wed, 16 Nov 2011 10:41:32 +0530
vbyravarasu@xxxxxxxxxx wrote:

> From: venu byravarasu <vbyravarasu@xxxxxxxxxx>
> 
> Current implementation of bin2bcd allows any value
> between 0x0 to 0xF to be stored in the most significant
> nibble of its returned value, against to the BCD limits
> of 0 - 9. Hence fixing it.
> 
> e.g. say val passed to bin2bcd is 123.
> In that case the expected value to be returned by
> this function is 0x23.
> However, without the fix being added, it would
> return 0xC3.
> 

I'm not sure that I agree.  Passing 123 to bin2bcd() is a bug, isn't
it?  We want to know about bugs so we can fix them, and quietly repairing
thngs in callees prevents that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/