Re: [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan_cfgregister on resume

From: Vinod Koul
Date: Wed Nov 23 2011 - 05:53:13 EST


On Tue, 2011-11-22 at 11:50 +0530, Viresh Kumar wrote:
> On 11/22/2011 9:43 AM, Vinod Koul wrote:
> > On Thu, 2011-11-17 at 16:01 +0530, Viresh Kumar wrote:
> >> > In S2R all DMA registers are reset by hardware and thus they are required to be
> > When are they reset, whenever you leave channel idle or once you come
> > back from suspend?
>
> Whenever we do S2R, many power islands are switched off and so DMAC controller looses
> all its power. On resume, all registers are in their reset state.
then why not perform save and restore in your suspend and restore
callbacks. That way you don't pay penalty of doing that in every alloc
as you seem to be doing now?

--
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/