Re: [PATCH v7 3.2-rc2 4/30] uprobes: Define hooks for mmap/munmap.

[Peter Zijlstra]

On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote:
> +                       ret = install_breakpoint(vma->vm_mm, uprobe);
> +                       if (ret == -EEXIST) {
> +                               atomic_inc(&vma->vm_mm->mm_uprobes_count);
> +                               ret = 0;
> +                       } 

Aren't you double counting that probe position here? The one that raced
you to inserting it will also have incremented that counter, no?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/