Re: [PATCH] spi: nuc900: Include linux/module.h

From: Paul Gortmaker
Date: Wed Nov 23 2011 - 22:16:31 EST


[[PATCH] spi: nuc900: Include linux/module.h] On 24/11/2011 (Thu 11:10) Axel Lin wrote:

> Include linux/module.h to fix below build error:

Looks fine to me ; I'll assume that this is going upstream via the
nuc900 maintainer since the module split up is old news at this point
in time.

Thanks,
Paul.

>
> CC drivers/spi/spi-nuc900.o
> drivers/spi/spi-nuc900.c:484: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/spi/spi-nuc900.c:489: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:489: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:489: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/spi/spi-nuc900.c:489: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:490: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:490: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:490: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/spi/spi-nuc900.c:490: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:491: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:491: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:491: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/spi/spi-nuc900.c:491: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:492: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:492: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:492: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
> drivers/spi/spi-nuc900.c:492: warning: function declaration isn't a prototype
> make[2]: *** [drivers/spi/spi-nuc900.o] Error 1
> make[1]: *** [drivers/spi] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> drivers/spi/spi-nuc900.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-nuc900.c b/drivers/spi/spi-nuc900.c
> index 21c70b2..182e9c8 100644
> --- a/drivers/spi/spi-nuc900.c
> +++ b/drivers/spi/spi-nuc900.c
> @@ -8,6 +8,7 @@
> *
> */
>
> +#include <linux/module.h>
> #include <linux/init.h>
> #include <linux/spinlock.h>
> #include <linux/workqueue.h>
> --
> 1.7.5.4
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/