Re: [PATCH 0/8] serial: 8250: support hw-based RS485 direction control(finally!)

[Claudio Scordino]

Il 23/11/2011 16:03, Wolfram Sang ha scritto:
> On Wed, Nov 16, 2011 at 05:24:37PM +0100, Wolfram Sang wrote:
>> Some 8250-variants control the direction pin for RS485 in hardware. Linux has
>> RS485 support these days, so update the 8250-driver to adhere to that. There
>> have been attempts for mainlining this before. So, I started with the version
>> from Matthias which got no further comments, a proof-of-concept for the 16V2750
>> from Jürgen, and reworked it to match the current state of RS485 in Linux. Some
>> minor cleanup patches came along the way. Really looking forward to
>> comments/tags, because I think it is really time to get this functionality into
>> mainline once and for all ;)
> 
> Ping. Claudio? What do you think? 

Hi Wolfram,

	sorry for the delay, but I'm very busy these days.

I noticed that some of your patches revert the changes made by the previous patches in the 
same series. So I would have preferred having only one patch with the whole changes wrt to 
the mainline. 

However, I've understood that some of those patches come from a previous submission that you
preferred to not touch. And I can apply the whole series to check what are the actual changes,
so its' fine.

The RS485 part looks right. 

I had a superficial look also at the rest of the code, and its seems OK too.  But, honestly, I couldn't 
find the time to read it carefully.

Best regards,

	Claudio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/