Re: iwlagn is getting very shaky

[Emmanuel Grumbach]

> Yeah, that was my impression too, but still, I wanted to mention it.
>
>> I am already on week-end here and will look at it more carefully
>> later. First impression is that things are messy here. I guess we are
>> getting in a bad failure path that wasn't checked...
>
> No problem, I can cope with it.
>

you can always disable 11n: modprobe 11n_disable=1.

Well... Something is really weird here:
mac80211 requests from us to:
* start agg
* stop agg
* agg operational

this is not a legal sequence

BTW - I am under this impression that mac80211 hasn't been compiled
with HT debug flag. Can you please set this compilation flag ?

I also would like you to add this line in iwlagn_mac_ampdu_action:


static int iwlagn_mac_ampdu_action(struct ieee80211_hw *hw,
				   struct ieee80211_vif *vif,
				   enum ieee80211_ampdu_mlme_action action,
				   struct ieee80211_sta *sta, u16 tid, u16 *ssn,
				   u8 buf_size)
{
	struct iwl_priv *priv = hw->priv;
	int ret = -EINVAL;
	struct iwl_station_priv *sta_priv = (void *) sta->drv_priv;

	IWL_DEBUG_HT(priv, "A-MPDU action on addr %pM tid %d\n",
		     sta->addr, tid);

dump_stack();   <<<<========================================= new line

	if (!(priv->cfg->sku & EEPROM_SKU_CAP_11N_ENABLE))
		return -EACCES;



This will give an insight at why is mac80211 calling the driver and
better point me to the bug.


Thanks !
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/