Re: [patch 1/8] mm: oom_kill: remove memcg argument from oom_kill_task()

From: Balbir Singh
Date: Sun Nov 27 2011 - 19:37:23 EST


On Wed, Nov 23, 2011 at 9:12 PM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
>
> From: Johannes Weiner <jweiner@xxxxxxxxxx>
>
> The memcg argument of oom_kill_task() hasn't been used since 341aea2
> 'oom-kill: remove boost_dying_task_prio()'.  Kill it.
>
> Signed-off-by: Johannes Weiner <jweiner@xxxxxxxxxx>
> ---
>  mm/oom_kill.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 471dedb..fd9e303 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -423,7 +423,7 @@ static void dump_header(struct task_struct *p, gfp_t gfp_mask, int order,
>  }
>
>  #define K(x) ((x) << (PAGE_SHIFT-10))
> -static int oom_kill_task(struct task_struct *p, struct mem_cgroup *mem)
> +static int oom_kill_task(struct task_struct *p)
>  {
>        struct task_struct *q;
>        struct mm_struct *mm;
> @@ -522,7 +522,7 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
>                }
>        } while_each_thread(p, t);
>
> -       return oom_kill_task(victim, mem);
> +       return oom_kill_task(victim);
>  }
>

Looks good!

Balbir Singh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/