Re: [PATCH] perf tool: reset use_browser when compiled without NEWT

From: Arnaldo Carvalho de Melo
Date: Mon Nov 28 2011 - 12:09:51 EST


Em Mon, Nov 28, 2011 at 09:58:46AM -0700, David Ahern escreveu:
> Hi Arnaldo:
>
> didn't see this one in your queue or a response. Do you agree this is
> needed?

Well, I think we should provide a better explanation for this usecase,
i.e. the code as is will use --stdio in NO_NEWT=yes builds, but will
still offer --tui and if that is specified, will produce no output.

Perhaps it is best to either elide --tui in NO_NEWT builds or state that
the build doesn't support --tui more clearly.

Or are you seeing something else that you think needs fixing?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/