Re: [RFC v2] cdc-acm: Fix potential deadlock (lockdep warning)

[Havard Skinnemoen]

On Sun, Nov 27, 2011 at 1:37 PM, Havard Skinnemoen
<hskinnemoen@xxxxxxxxxx> wrote:
> -       if (0 > acm_set_control(acm, acm->ctrlout = ACM_CTRL_DTR | ACM_CTRL_RTS) &&
> +       acm->ctrlout = ACM_CTRL_DTR | ACM_CTRL_RTS;
> +       if (acm_set_control(acm, acm->ctrlout < 0) &&

Ok, so this is obviously broken. Unfortunately, my test setup doesn't
use the control signals in any way.

I'm sure I broke something else, so I'm going to wait a bit for others
to have a look before I post an updated patch.

Havard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/