Re: [PATCH] watchdog: fix nowayout setting in s3c2410_wdt

[Wim Van Sebroeck]

Hi Wolfram,

> > +/* Use the following function to set the nowayout feature */
> > +static inline void watchdog_set_nowayout(struct watchdog_device *wdd, int nowayout)
> > +{
> > +	if (nowayout)
> > +		set_bit(WDOG_NO_WAY_OUT, &wdd->status);
> > +}
> 
> Yes, this is better in case we might need to add something later.
> 
> > but: .status = WATCHDOG_NOWAYOUT_INIT_STATUS, is also a nice one to have.
> > 
> > I propose to add both options and to document them in the documentation.
> > Objections anyone?
> 
> Sounds good to me.
> 
> So, I'll drop NOWAYOUT-related patches from my STMP-series?

Yes, I'll make sure we do the necessary on the nowayout side :-). Will try to add a patch for it today.
Could you resend the SMTP series after that you dropped the nowayout patches so I can review these?

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/