Re: [PATCH v2 0/8][NET] fec.c: several cleanups and bugfixes

From: Shawn Guo
Date: Thu Dec 08 2011 - 02:05:38 EST


On 8 December 2011 15:01, Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> David Miller writes:
>> From: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx>
>> Date: Wed,  7 Dec 2011 14:37:12 +0100
>>
>> > The following set of patches provides some cleanup and bugfixes for
>> > drivers/net/ethernet/freescale/fec.c and makes the driver buildable as
>> > a module.
>>
>> 1) I said to use a subject prefix of "fec: " not "fec.c: "
>>
> OK.

To be consistent with existing commits, I would suggest use "net/fec:
" as the subject prefix.

>
>> 2) You did not integrate Shawn's "Acked-by: " tags, I'm not going to
>>    go sifting through the previous patch postings to collect them up,
>>    that's your job.
>>
> I still got no Ack from Shawn for patches 3 and 5 and only Tested-by
> for patches 6 thru 8. Should I wait for Shawn's Ack for those patches
> too, or should I resent now?
>
For the whole series,

Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx>

--
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/