Re: [PATCH 4/7] amp/omap: add a remoteproc driver

[Ohad Ben-Cohen]

Hi Tony,

On Tue, Oct 25, 2011 at 11:48 AM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> Add a remoteproc driver for OMAP4, so we can boot the dual-M3 "Ducati"
> and DSP subsystems.
>
> Use the omap_device_* API to control the hardware state, and utilize
> the OMAP mailbox to interrupt the remote processor when a new message
> is pending (the mailbox payload is used to tell it which virtqueue was
> the message placed in).
>
> Conversely, when an inbound mailbox message arrives, tell the remoteproc
> core which virtqueue is triggered.
>
> Later we will also use the mailbox payload to signal omap-specific
> events like remote crashes (which will be used to trigger remoteproc
> recovery) and power management transitions. At that point we will also
> extend the remoteproc core to support this.
>
> Based on (but now quite far from) work done by Fernando Guzman Lugo
> <fernando.lugo@xxxxxx> and Hari Kanigeri <h-kanigeri2@xxxxxx>.
>
> Designed with Brian Swetland <swetland@xxxxxxxxxx>.
>
> Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
> Cc: Brian Swetland <swetland@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Greg KH <greg@xxxxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> ---
>  arch/arm/plat-omap/include/plat/remoteproc.h |   56 ++++++
>  drivers/amp/remoteproc/Kconfig               |   21 +++
>  drivers/amp/remoteproc/Makefile              |    4 +-
>  drivers/amp/remoteproc/omap_remoteproc.c     |  248 ++++++++++++++++++++++++++
>  drivers/amp/remoteproc/omap_remoteproc.h     |   69 +++++++
>  5 files changed, 397 insertions(+), 1 deletions(-)
>  create mode 100644 arch/arm/plat-omap/include/plat/remoteproc.h
>  create mode 100644 drivers/amp/remoteproc/omap_remoteproc.c
>  create mode 100644 drivers/amp/remoteproc/omap_remoteproc.h

I'm about to add this to linux-next (minus the 'amp' wording); can I
please have your Acked-by for this (at least for the plat-omap change) ?

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/