Re: [PATCH 1/2] hwmon: jz4740: fix signedness bug

[Lars-Peter Clausen]

On 12/08/2011 02:04 PM, Axel Lin wrote:
> wait_for_completion_interruptible_timeout() may return negative value.
> In this case, checking if (t > 0)  will return true if t is unsigned.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

Thanks

> ---
>  drivers/hwmon/jz4740-hwmon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
> index 7a48b1e..3d7e590 100644
> --- a/drivers/hwmon/jz4740-hwmon.c
> +++ b/drivers/hwmon/jz4740-hwmon.c
> @@ -59,7 +59,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev,
>  {
>  	struct jz4740_hwmon *hwmon = dev_get_drvdata(dev);
>  	struct completion *completion = &hwmon->read_completion;
> -	unsigned long t;
> +	long t;
>  	unsigned long val;
>  	int ret;
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/