Re: [PATCH 1/1] USB: Adding #define in hub_configure() and hcd.cfile

[Alan Stern]

On Thu, 8 Dec 2011, Aman Deep wrote:

> This patch is in succession of previous patch
> commit c8421147926fcacf53081a36438a0bed394da9f5
>         xHCI: Adding #define values used for hub descriptor
> 
> Hub descriptors characteristics #defines values are added in
> hub_configure() in place of magic numbers as asked by Alan Stern.
> And the indentation for switch and case is changed to be same.
> 
> Some #defines values are added in ch11.h for defining hub class
> protocols and used in hub.c and hcd.c in which magic values were
> used for hub class protocols.
> 
> Signed-off-by: Aman Deep <amandeep3986@xxxxxxxxx>

I like it!

If you're looking for more things to work on, consider the #defines in
ch11.h for the various port features and statuses.  Some of the newer
USB-3 entries were added in the wrong place, or even added twice!  It
would be good to get that straightened up.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/