RE: [PATCH 1/1] input: keyboard: Set configuration registers

[Stephen Warren]

Shridhar Rasal wrote at Friday, December 09, 2011 12:29 AM:
> To: dmitry.torokhov@xxxxxxxxx
> Cc: rydberg@xxxxxxxxxxx; Stephen Warren; Rakesh Iyer; linux-kernel@xxxxxxxxxxxxxxx; linux-
> input@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; Shridhar Rasal
> Subject: [PATCH 1/1] input: keyboard: Set configuration registers
> 
> -Set only REQUIRED row and column configuration register to
> PROPER values to avoid continuously generating KBC input events.
> -Use *en* field in pin_cfg, to check GPIO_x_ROW_EN register
> should be set or clear.
> 
> Signed-off-by: Shridhar Rasal <srasal@xxxxxxxxxx>

I wondered if num==0 could be used instead of a new en field, but 0 is a
valid row/column number, so no. As such,

Acked-by: Stephen Warren <swarren@xxxxxxxxxx>

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/