Re: [PATCH V3 1/2] xen/granttable: Support sub-page grants

[ANNIE LI]

On 2011-12-10 1:38, Ian Campbell wrote:
> On Fri, 2011-12-09 at 11:32 +0000, annie.li@xxxxxxxxxx wrote:
> > -- They can't be used to map the page (so can only be used in a GNTTABOP_copy
> >         hypercall).
> >      -- It's possible to grant access with a finer granularity than whole pages.
> >      -- Xen guarantees that they can be revoked quickly (a normal map grant can
> >         only be revoked with the cooperation of the domain which has been granted
> >         access).
> >
> > Signed-off-by: Annie Li<annie.li@xxxxxxxxxx>
> > ---
> >   drivers/xen/grant-table.c |   71 +++++++++++++++++++++++++++++++++++++++++++++
> >   include/xen/grant_table.h |   13 ++++++++
> >   2 files changed, 84 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> > index bd325fd..0ac16fa 100644
> > --- a/drivers/xen/grant-table.c
> > +++ b/drivers/xen/grant-table.c
> > @@ -120,6 +120,16 @@ struct gnttab_ops {
> >   	 * by bit operations.
> >   	 */
> >   	int (*query_foreign_access)(grant_ref_t);
> > +	/*
> > +	 * Grant a domain to access a range of bytes within the page referred by
> > +	 * an available grant entry. First parameter is grant entry reference
> > +	 * number, second one is id of grantee domain, third one is frame
> > +	 * address of subpage grant, forth one is grant type and flag
> > +	 * information, fifth one is offset of the range of bytes, and last one
> > +	 * is length of bytes to be accessed.
> > +	 */
> > +	void (*update_subpage_entry)(grant_ref_t, domid_t, unsigned long, int,
> > +				     unsigned, unsigned);
> Please can you name the arguments here and then refer to them by name in
> the comments instead of all this "First parameter", "second one" stuff.
>
> Similarly for the existing comments sorry I didn't notice this in
> previous review.
Ok, I will do this in another separate patch.

Thanks,
Annie.
> Ian.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/