Re: [PATCH] fs, proc: Add start_data, end_data, start_brk members to/proc/$pid/stat v2

[Cyrill Gorcunov]

On Sun, Dec 11, 2011 at 11:30:21PM -0800, Eric W. Biederman wrote:
> Cyrill Gorcunov <gorcunov@xxxxxxxxx> writes:
> 
> > On Wed, Dec 07, 2011 at 10:33:08AM +0400, Cyrill Gorcunov wrote:
> >> 
> >> No problem, I'll update (These segments are filled by binfmt handlers).
> >> 
> >
> > This one should fit.
> 
> How extensively have you tested this.  I remember a few other occasions
> where adding elements to a line in a proc file have resulted in breaking
> readers.
> 

Hmm. Tested it pretty heavy on centos 5 series. I'll dig some more.

> I expect it is much safer to add this to /proc/<pid>/status rather than
> /proc/<pid>/stat.
> 

Eric, I'm fine with any file. I thought about /.../stat only because it
already has start_code/end_code, so to have all pieces in one place this
file was choosen.

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/