Re: [PATCH] Input: bcm5974 - Fix USB autosuspend

[Oliver Neukum]

Am Montag, 12. Dezember 2011, 10:06:04 schrieb Henrik Rydberg:
> @@ -895,6 +857,10 @@ static int bcm5974_probe(struct usb_interface *iface,
>         /* save our data pointer in this interface device */
>         usb_set_intfdata(iface, dev);
>  
> +       error = bcm5974_start_traffic(dev);
> +       if (error)
> +               goto err_free_buffer;
> +
>         return 0;
>  
>  err_free_buffer:
> -- 

Why do you want to start traffic before open() in probe() ?
It doesn't make sense to ask a device to deliver data nobody
wants.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/