Re: [PATCH -next] proc: fix task_struct infoleak

[Vasiliy Kulikov]

On Sun, Dec 11, 2011 at 20:59 +0000, Al Viro wrote:
> On Sun, Dec 11, 2011 at 10:28:21PM +0400, Vasiliy Kulikov wrote:
> > proc_pid_permission() doesn't put task_struct on every /proc/$pid/
> > access.  A demo from Hugh Dickins:
> > 
> > while :; do ps; grep KernelStack /proc/meminfo; sleep 1; done
> > 
> > Reported-by: Hugh Dickins <hughd@xxxxxxxxxx>
> > Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx>
> > ---
> >  This is a patch against a hidepid patchset from -mm.
> 
> Choose saner commit summary, please.  It's not information leak, for pity sake
> - it's a plain and simple memory leak...

Oops!  s/infoleak/memleak/ surely, bad habit...

Thank you, I'll resend the patch.


-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/