Re: [PATCH 1/2] Add partition resize function to BLKPG ioctl

From: Vivek Goyal
Date: Mon Dec 12 2011 - 09:53:36 EST


On Thu, Dec 08, 2011 at 09:53:09PM -0500, Phillip Susi wrote:
> On 12/08/2011 11:28 AM, Vivek Goyal wrote:
> > I thought I have found couple of places where we don't take mutex. For
> > example.
>
> I merged your seq changes into my patch. How does this look?

Can you please inline the patch so that reviewing becomes easier. Right
now it is an attachment.

Couple of quick comments.

- I think during copy/paste tabs have been replaced by spaces at places.
- You have retained function extend_partition() from my patch. I think you
are not using it.
- Can we rename BLKPG_RES_PARTITION to BLKPG_RESIZE_PARTITION. It is
easier to read.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/