Re: [PATCH 1/3] kref: Inline all functions

From: Greg KH
Date: Mon Dec 12 2011 - 17:12:09 EST


On Sat, Dec 10, 2011 at 11:43:42AM +0100, Peter Zijlstra wrote:
> These are tiny functions, there's no point in having them out-of-line.

Nice, but this breaks the build:

CC init/main.o
In file included from include/linux/kobject.h:24:0,
from include/linux/module.h:16,
from init/main.c:13:
include/linux/kref.h: In function âkref_putâ:
include/linux/kref.h:62:2: error: âkfreeâ undeclared (first use in this function)
include/linux/kref.h:62:2: note: each undeclared identifier is reported only once for each function it appears in
include/linux/kref.h: In function âkref_subâ:
include/linux/kref.h:91:2: error: âkfreeâ undeclared (first use in this function)
make[1]: *** [init/main.o] Error 1
make: *** [init] Error 2

Sorry, I can't apply this.

This was on an x86-64 build, my "stock" desktop system, nothing "odd" in the
config at all...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/