Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressurecontrols

[Glauber Costa]

On 12/13/2011 05:59 PM, Eric Dumazet wrote:
> Le mardi 13 dÃcembre 2011 Ã 14:49 +0100, Christoph Paasch a Ãcrit :
>
> > now there are plenty of compiler-warnings when CONFIG_CGROUPS is not set:
> >
> > In file included from include/linux/tcp.h:211:0,
> >                   from include/linux/ipv6.h:221,
> >                   from include/net/ip_vs.h:23,
> >                   from kernel/sysctl_binary.c:6:
> > include/net/sock.h:67:57: warning: âstruct cgroup_subsysâ declared
> > inside parameter list [enabled by default]
> > include/net/sock.h:67:57: warning: its scope is only this definition or
> > declaration, which is probably not what you want [enabled by default]
> > include/net/sock.h:67:57: warning: âstruct cgroupâ declared inside
> > parameter list [enabled by default]
> > include/net/sock.h:68:61: warning: âstruct cgroup_subsysâ declared
> > inside parameter list [enabled by default]
> > include/net/sock.h:68:61: warning: âstruct cgroupâ declared inside
> > parameter list [enabled by default]
> >
> >
> > Because struct cgroup is only declared if CONFIG_CGROUPS is enabled.
> > (cfr. linux/cgroup.h)
>
> Yes, we probably need forward reference like this :
>
> Thanks !
>
> [PATCH net-next] net: fix build error if CONFIG_CGROUPS=n
>
> Reported-by: Christoph Paasch<christoph.paasch@xxxxxxxxxxxx>
> Signed-off-by: Eric Dumazet<eric.dumazet@xxxxxxxxx>
I am deeply sorry about that.
I was pretty sure I tested this case. But now that I looked into it, it 
occurs to me that I may have tested it only with the Memory Cgroup 
disabled, not with the master flag off.

Thanks for spotting this

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/