Re: [PATCH v3 resend2] s3c/s3c24xx: arm: leds: Make s3c24xx LEDSdriver use gpiolib

From: Denis Kuzmenko
Date: Tue Dec 13 2011 - 16:35:22 EST


On 12/13/2011 11:28 PM, Joe Perches wrote:
> On Tue, 2011-12-13 at 23:21 +0200, Denis Kuzmenko wrote:
>> Hi Joe,
>> Thank you for review.
>>
>> On 12/13/2011 11:06 PM, Joe Perches wrote:
>>> On Tue, 2011-12-13 at 22:22 +0200, Denis Kuzmenko wrote:
>>>> Make s3c24xx LEDS driver use gpiolib. Fix error disabling pull during probe.

> Your choice, but I think consistency is better.
>
> The LEDF_ACTLOW use is dependent on it being #defined
> to 1 when using ^. I think that's unintelligible.

Sorry, can't understand. Can you please clarify last two sentences?

--
Best regards, Denis Kuzmenko.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/