RE: [PATCH V2 2/2] ARM: mmp: enable pinmux in platform driver

[Stephen Warren]

Linus Walleij wrote at Tuesday, December 13, 2011 4:02 PM:
> On Tue, Dec 13, 2011 at 10:40 AM, Haojian Zhuang wrote:
...
> > +static struct pinmux_map brownstone_pmx_map[] = {
> > +       {
> > +               .name = "dkin",
> > +               .ctrl_dev_name = "mmp2-pinmux",
> > +               .function = "dkin",
> > +               .group = "dkin-2-pin",
> > +               .hog_on_boot = true,
> > +       }, {
...
> 
> Looks like we want to add
> #define PINMUX_MAP_SYS_HOG_GROUP() or so with four
> arguments, what do you say Stephen? Shall I try to patch  in
> something like that (then this patch will look even better).

Yes, sounds like a good idea. I just realized that I ignored PINMUX_MAP_*
in the stuff I'm working on and implemented exactly that macro as a custom
macro right before the map array. So, having it in the pinctrl header
would be good. 

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/