Re: [PATCH 1/1] Staging: zram: print the disk size in KB

[Greg KH]

On Tue, Dec 13, 2011 at 10:46:53AM +0530, Ajeet Yadav wrote:
> >From a5d5ba92b5af9134e617986884856334c377e1d0 Mon Sep 17 00:00:00 2001
> From: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>
> Date: Mon, 12 Dec 2011 18:42:30 +0530
> Subject: [PATCH 1/1] Staging: zram: print the disk size in KB

Why did you include the patch in an email instead of using
git-send-email?  This would force me to edit the patch by hand, removing
this useless stuff.

> 
> Total memory size is in KB, but the zram disk size was not
> printed in KB, correct the figure in KB units.
> 
> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>
> ---
>  drivers/staging/zram/zram_drv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> index 09de99f..ff591e3 100644
> --- a/drivers/staging/zram/zram_drv.c
> +++ b/drivers/staging/zram/zram_drv.c
> @@ -126,7 +126,7 @@ static void zram_set_disksize(struct zram *zram,
> size_t totalram_bytes)

And your patch is line-wrapped, making it so I would have to edit it
again.

Please fix up, and get the acks from the zram maintainer (as this does
change a kernel/user api) before I can accept this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/