Re: [PATCH-WIP] convert CPU sysdev class to a real subsytem (neededfor CPU modaliases)

[Kay Sievers]

On Wed, Dec 14, 2011 at 02:21, Greg KH <greg@xxxxxxxxx> wrote:
> On Wed, Dec 14, 2011 at 01:50:57AM +0100, Kay Sievers wrote:
>> On Fri, Dec 9, 2011 at 23:34, Greg KH <greg@xxxxxxxxx> wrote:
>> > On Fri, Dec 09, 2011 at 04:25:21PM +0100, Kay Sievers wrote:
>> >> Greg, would be nice, if you can take a quick look a the driver core (not
>> >> the sysdev) bits in core.c, bus.c, device.h, ... and its interaction, if
>> >> they look sane to you. I'll then split the driver core stuff out, so we
>> >> can merge that before we port the individual drivers over.
>> >
>> > Yes, it looks sane to me, thanks again for doing this work.
>>
>> Split-up patches are here:
>> Â http://git.kernel.org/?p=linux/kernel/git/kay/patches.git;a=tree
>>
>> That's the size of it:
>> Â 60 files changed, 1170 insertions(+), 1421 deletions(-)
>
> Very nice.
>
>> The current state and the list of the remaining non-x86 files is here:
>> Â http://git.kernel.org/?p=linux/kernel/git/kay/patches.git;a=blob;f=README;hb=HEAD
>>
>> We need a plan now. :)
>
> If I take those patches, none of those other ones will break their
> build, right?

The first patch should not break anything, the non-core things shouldn't too.

> Or will the cpu ones?

The cpu patch as it is will break power, s390, sh and tile.
  $ git grep -w -l cpu_sysdev_class
  arch/powerpc/kernel/sysfs.c
  arch/powerpc/platforms/pseries/pseries_energy.c
  arch/s390/kernel/smp.c
  arch/sh/kernel/cpu/sh4/sq.c
  arch/tile/kernel/sysfs.c

If all should be bisectable, we would need to merge these changes into
the cpu patch.

The other two core patches, node and memory, could need arch fixes
too, but a quick grep did not reveal anything.

> I'll look at this tomorrow, gotta go now,

Great.

> I'm burnt out by badly written
> staging patches that must have been created by someone who is bent on
> driving me crazy.

Hehe, you must have expected all that when you came up with the
TAINT_* flag name. :)

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/