Re: [PATCH 1/1] Staging: zram: print the disk size in KB

[Geert Uytterhoeven]

On Tue, Dec 13, 2011 at 06:16, Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx> wrote:
> From a5d5ba92b5af9134e617986884856334c377e1d0 Mon Sep 17 00:00:00 2001
> From: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>
> Date: Mon, 12 Dec 2011 18:42:30 +0530
> Subject: [PATCH 1/1] Staging: zram: print the disk size in KB
>
> Total memory size is in KB, but the zram disk size was not
> printed in KB, correct the figure in KB units.

Kelvin bytes?

> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>
> ---
> Âdrivers/staging/zram/zram_drv.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> index 09de99f..ff591e3 100644
> --- a/drivers/staging/zram/zram_drv.c
> +++ b/drivers/staging/zram/zram_drv.c
> @@ -126,7 +126,7 @@ static void zram_set_disksize(struct zram *zram,
> size_t totalram_bytes)
> Â Â Â Â Â Â Â Â"\tMemory Size: %zu kB\n"

kilobytes? Either this ...

> Â Â Â Â Â Â Â Â"\tSize you selected: %llu kB\n"

... and this should be KiB ...

> Â Â Â Â Â Â Â Â"Continuing anyway ...\n",
> - Â Â Â Â Â Â Â totalram_bytes >> 10, zram->disksize
> + Â Â Â Â Â Â Â totalram_bytes >> 10, zram->disksize >> 10

... or these should be / 1000 instead of >> 10.

> Â Â Â Â Â Â Â Â);
> Â Â Â Â}

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/