Re: [PATCH V2 1/2] pinctrl: enable pinmux for pxa series

[Arnd Bergmann]

On Tuesday 13 December 2011, Stephen Warren wrote:
> Haojian Zhuang wrote at Tuesday, December 13, 2011 2:41 AM:
> 
> > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> 
> > +obj-$(CONFIG_PINMUX_PXA168)	+= pinmux-pxa168.o pinctrl-pxa3xx.o
> > +obj-$(CONFIG_PINMUX_PXA300)	+= pinmux-pxa300.o pinctrl-pxa3xx.o
> > +obj-$(CONFIG_PINMUX_PXA910)	+= pinmux-pxa910.o pinctrl-pxa3xx.o
> 
> That structure will cause problems if multiple of those Kconfig options
> are enabled at once, as in a multi-SoC kernel. Instead, shouldn't this be:
> 
> obj-$(CONFIG_PINCTRL_PXA3XX)	+= pinctrl-pxa3xx.o
> obj-$(CONFIG_PINMUX_PXA168)	+= pinmux-pxa168.o
> obj-$(CONFIG_PINMUX_PXA300)	+= pinmux-pxa300.o
> obj-$(CONFIG_PINMUX_PXA910)	+= pinmux-pxa910.o

I'm pretty sure the first version is ok too, as long as none of the
options can be built as modules.  Your version seems to be more common though.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/