Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux subsystem

[Sascha Hauer]

On Thu, Dec 15, 2011 at 08:59:28AM +0000, Dong Aisheng-B29396 wrote:
> > -----Original Message-----
> > From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx]
> > Sent: Thursday, December 15, 2011 4:27 PM
> > To: Guo Shawn-R65073
> > Cc: Sascha Hauer; Dong Aisheng-B29396; linus.walleij@xxxxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx; rob.herring@xxxxxxxxxxx;
> > grant.likely@xxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > kernel@xxxxxxxxxxxxxx
> > Subject: Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux
> > subsystem
> > Importance: High
> > 
> > On Thu, Dec 15, 2011 at 8:05 AM, Shawn Guo <shawn.guo@xxxxxxxxxxxxx>
> > wrote:
> > >[Me]
> > >> So if you want to do this for i.MX you need something like selectable
> > >> dummy pinmuxes, i.e. pinmux_get() to return something that just say
> > >> "OK" to everything like the dummy regulators.
> > >>
> > >> Shall I try to create something like that?
> > >>
> > > Isn't the empty functions defined in include/linux/pinctrl/pinmux.h
> > > for this purpose?
> > 
> > No, these are for compiling it *out*, dummy pinmuxes would be if you
> > compile it *in*, but don't find an apropriate pinmux, you still get
> > something that does nothing and still works.
> > 
> > Dummy regulators work exactly this way.
> > 
> 
> I did not read the dummy regulator code too much.
> But does it mean that the dummy regulator or dummy pinmux will also hide the
> Real errors since it will always get a available one?
> How do we distinguish between the two case(real error and fake error)?

We don't :(

That's the problem with the dummy regulator.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/