Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

[Thomas Renninger]

On Thursday 15 December 2011 19:06:08 Seth Forshee wrote:
> toshiba_acpi needs to execute an AML method within the EC namespace
> to make hotkeys work on some platforms. Provide an interface to
> allow it to easily get a handle to the EC namespace for this purpose.
I first liked the idea of making the ec device more global for others
to access.
But thinkpad_acpi is doing the same already in another way.

I think best is to move the thinkpad implementation of getting
ACPI handles based on HIDs to osl.c and make it global.
I'll send patches.
Please review them carefully, they are only compile tested.

      Thomas

> 
> Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
> ---
>  drivers/acpi/ec.c    |   10 ++++++++++
>  include/linux/acpi.h |    1 +
>  2 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index b19a18d..e37615f 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -445,6 +445,16 @@ int ec_transaction(u8 command,
>  
>  EXPORT_SYMBOL(ec_transaction);
>  
> +/* Get the handle to the EC device */
> +acpi_handle ec_get_handle(void)
> +{
> +	if (!first_ec)
> +		return NULL;
> +	return first_ec->handle;
> +}
> +
> +EXPORT_SYMBOL(ec_get_handle);
> +
>  void acpi_ec_block_transactions(void)
>  {
>  	struct acpi_ec *ec = first_ec;
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 6001b4da..ecccbb7 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -151,6 +151,7 @@ extern int ec_write(u8 addr, u8 val);
>  extern int ec_transaction(u8 command,
>                            const u8 *wdata, unsigned wdata_len,
>                            u8 *rdata, unsigned rdata_len);
> +extern acpi_handle ec_get_handle(void);
>  
>  #if defined(CONFIG_ACPI_WMI) || defined(CONFIG_ACPI_WMI_MODULE)
>  
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/