Re: [PATCH] Use 'do {} while (0)' for empty flush_tlb_fix_spurious_fault()macro

[Michel Lespinasse]

On Sat, Dec 17, 2011 at 4:32 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> If one builds the kernel with -Wempty-body one gets this warning:
>
>  mm/memory.c:3432:46: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>
> due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that
> can sometimes be defined to nothing.
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Looks good to me. I'd be happy with either that or Al's alternative suggestion.

Reviewed-by: Michel Lespinasse <walken@xxxxxxxxxx>

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/