RE: [PATCH 1/2] MFD: TPS65217: Add new mfd device for TPS65217

[AnilKumar, Chimata]

Hi Mark,

> > 
> > > +/* All register addresses */
> > > +#define TPS65217_REG_CHIPID		0X00
> > 
> > You should verify this as part of the probe() routine - read it back to
> > make sure it's what's expected, and log the chip revision too in case it
> > is useful for diagnostics.
> > 
> 
> Added chip verification code to mfd probe and printing the regulator ID &
> version number.

TPS65217 has two versions A and B.
i.  TPS65217A - not supporting DVFS on AM335X
ii. TPS65217B - supports DVFS on AM335X

Right now I am supporting the version B but not A since I am testing DVFS on
AM335X.

I have BeagleBone with me having TPS65217B, but the CHIPID reads 0x70
(corresponds to TPS65217A)!
I am discussing with hardware folks on what to do about this, but for
now I will skip interpreting the CHIPID. I can print it out for reference
though.

Thanks
AnilKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/