Re: [PATCH] dmaengine/ste_dma40: clear LNK on channel startup

[Vinod Koul]

On Wed, 2011-12-28 at 11:27 +0530, Narayanan G wrote:
> From: Rabin Vincent <rabin.vincent@xxxxxxxxxxxxxx>
> 
> Otherwise if a previously physical channel is used as a logical channel, the
> LNK may have old values which affect the operation of the logical channel since
> the LNK register has different semantics between physical and logical channels.
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@xxxxxxxxxxxxxx>
> Reviewed-by: Jonas ABERG <jonas.aberg@xxxxxxxxxxxxxx>
> Signed-off-by: Narayanan G <narayanan.gopalakrishnan@xxxxxxxxxxxxxx>
> ---
>  drivers/dma/ste_dma40.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index 972dc35..cc5ecbc
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -1104,6 +1104,10 @@ static void d40_config_write(struct d40_chan *d40c)
>  		/* Set LIDX for lcla */
>  		writel(lidx, chanbase + D40_CHAN_REG_SSELT);
>  		writel(lidx, chanbase + D40_CHAN_REG_SDELT);
> +
> +		/* Clear LNK which will be used by d40_chan_has_events() */
> +		writel(0, chanbase + D40_CHAN_REG_SSLNK);
> +		writel(0, chanbase + D40_CHAN_REG_SDLNK);
>  	}
>  }
>  
Applied, Thanks

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/