Re: [PATCH] module: log OOT_MODULE tainting

From: Jiri Kosina
Date: Tue Jan 03 2012 - 03:47:04 EST


On Tue, 3 Jan 2012, Rusty Russell wrote:

> > Follow what we do with other taints and output a message into kernel ring
> > buffer once tainting a kernel because out-of-tree module is being loaded.
> >
> > Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
>
> I don't like this, actually. There's a wish among some distributions to
> know that OOT modules are in use in panic messages, but not by others.
> Certainly, there's no reason to warn the user.

I do get your point, but it seems to me that we are at least not
consistent here. Why would we then log messages in cases of
TAINT_FORCED_MODULE for example? The user knows that he has forced the
module load, right?

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/