Re: [PATCH 12/15] module_param: make bool parameters really bool(drivers & misc)

[Dan Carpenter]

> diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
> --- a/drivers/video/intelfb/intelfbdrv.c
> +++ b/drivers/video/intelfb/intelfbdrv.c
> @@ -230,16 +230,16 @@ MODULE_DESCRIPTION("Framebuffer driver f
>  MODULE_LICENSE("Dual BSD/GPL");
>  MODULE_DEVICE_TABLE(pci, intelfb_pci_table);
>  
> -static int accel        = 1;
> +static bool accel       = 1;
>  static int vram         = 4;
> -static int hwcursor     = 0;
> -static int mtrr         = 1;
> -static int fixed        = 0;
> -static int noinit       = 0;
> -static int noregister   = 0;
> -static int probeonly    = 0;
> -static int idonly       = 0;
> -static int bailearly    = 0;
> +static bool hwcursor    = 0;
> +static bool mtrr        = 1;
> +static bool fixed       = 0;
> +static bool noinit      = 0;
> +static bool noregister  = 0;
> +static bool probeonly   = 0;
> +static bool idonly      = 0;
> +static bool bailearly   = 0;

bailearly should be an int here.  It's part of some ugly debug code
where a value of 3 means bailout at point 3.  Maybe we should just
remove it instead...

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature