Re: Add Dell Studio 1557 to pci=nocrs blacklist

From: Jesse Barnes
Date: Wed Jan 04 2012 - 12:08:44 EST


On Wed, 4 Jan 2012 11:33:12 -0500
Dave Jones <davej@xxxxxxxxxx> wrote:

> The Dell Studio 1557 also doesn't suspend correctly when CRS is enabled.
> Details at https://bugzilla.redhat.com/show_bug.cgi?id=769657
>
> Reported-by: Gregory S. Hoerner <ghoerner@xxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
>
> --- linux-3.1.noarch/arch/x86/pci/acpi.c~ 2012-01-04 11:19:36.783664477 -0500
> +++ linux-3.1.noarch/arch/x86/pci/acpi.c 2012-01-04 11:23:42.403666272 -0500
> @@ -75,6 +75,16 @@ static const struct dmi_system_id pci_us
> /* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
> {
> .callback = set_nouse_crs,
> + .ident = "Dell Studio 1557",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1557");
> + DMI_MATCH(DMI_BIOS_VERSION, "A09"),
> + },
> + },
> + /* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
> + {
> + .callback = set_nouse_crs,
> .ident = "Thinkpad SL510",
> .matches = {
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>

Looks like this depends on a Thinkpad patch you haven't sent yet; did
you mean to?

I've fixed it up by hand and applied both the 1536 and 1557 patches to
my for-linus branch. I'll see if Linus wants to take it before he
releases (doubtful, but it would be nice if these machines just worked
with the new kernel).

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature