Re: [PATCH] rtl8192cu: Fix WARNING on suspend/resume

[Larry Finger]

On 01/04/2012 10:16 AM, Daniel Halperin wrote:
> Sorry, Larry, I didn't see this til it was included in John's mail this morning.
>
> On Tue, Jan 3, 2012 at 10:39 AM, Larry Finger<Larry.Finger@xxxxxxxxxxxx>  wrote:
> > +#ifdef CONFIG_PM
> > +static int rtl8192cu_usb_suspend(struct usb_interface *pusb_intf,
> > +                                pm_message_t message)
> > +{
> > +       /* Increase usage_count to Save loaded fw across suspend/resume */
> > +       atomic_inc(&usage_count);
> > +       return 0;
> > +}
> > +
> > +static int rtl8192cu_usb_resume(struct usb_interface *pusb_intf)
> > +{
> > +       atomic_dec(&usage_count);       /* after resume, decrease usage count */
> > +       return 0;
> > +}
> > +#endif
>
> Based on the warning-fix I submitted yesterday, this probably produces
> a warning if CONFIG_PM is set but not CONFIG_PM_SLEEP. My patch was
> for an ethernet driver, but iwlwifi and ath5k appear to follow the
> same pattern using CONFIG_PM_SLEEP instead of the above.
>
> See: http://www.spinics.net/lists/netdev/msg184717.html for the patch
> and http://www.spinics.net/lists/netdev/msg184715.html for the
> discussion.

Thanks for the note. I will prepare a revised patch.

What architecture gave the warning? Of x86_64, I was unable to get 
CONFIG_PM_SLEEP without CONFIG_PM.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/