Re: [PATCH] include: crash_dump.h: Add elf.h header

[Andrew Morton]

On Wed,  4 Jan 2012 10:04:26 -0200
Fabio Estevam <festevam@xxxxxxxxx> wrote:

> Building an ARM target we get the following warnings:
> 
> CC      arch/arm/kernel/setup.o
> In file included from arch/arm/kernel/setup.c:39:
> arch/arm/include/asm/elf.h:102:1: warning: "vmcore_elf64_check_arch" redefined
> In file included from arch/arm/kernel/setup.c:24:
> include/linux/crash_dump.h:30:1: warning: this is the location of the previous definition
> 
> Quoting Russell King:
> 
> "linux/crash_dump.h makes no attempt to include asm/elf.h, but it depends
> on stuff in asm/elf.h to determine how stuff inside this file is defined
> at parse time.
> 
> So, if asm/elf.h is included after linux/crash_dump.h or not at all, you
> get a different result from the situation where asm/elf.h is included
> before."
> 
> So add elf.h header to crash_dump.h to avoid this problem.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
> The original discussion about this can be found at:
> http://www.spinics.net/lists/arm-kernel/msg154113.html
> 
>  include/linux/crash_dump.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 5c4abce..b936763 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -5,6 +5,7 @@
>  #include <linux/kexec.h>
>  #include <linux/device.h>
>  #include <linux/proc_fs.h>
> +#include <linux/elf.h>
>  
>  #define ELFCORE_ADDR_MAX	(-1ULL)
>  #define ELFCORE_ADDR_ERR	(-2ULL)

The patch is the right thing to do, however I'm rather concerned about
the potential for introducing build breakage so late in 3.2.

Can we leave this unfixed in 3.2 and fix it in 3.2.1?  Or put a
#include elf.h into arch/arm/kernel/setup.c for 3.2?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/