Re: linux-next: build warning after merge of the vfs tree

[Stephen Rothwell]

Hi Al,

On Thu, 5 Jan 2012 08:06:57 +0000 Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Jan 05, 2012 at 05:35:21PM +1100, Stephen Rothwell wrote:
> > 
> > After merging the vfs tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > fs/reiserfs/super.c:701:2: warning: initialization from incompatible pointer type [enabled by default]
> > fs/reiserfs/super.c:701:2: warning: (near initialization for 'reiserfs_sops.show_options') [enabled by default]
> > 
> > Caused by commit 2ddeb2a58b11 ("vfs: switch ->show_options() to struct
> > dentry *") interacting with commit f1823b7b87d1 ("reiserfs: Properly
> > display mount options in /proc/mounts") from the ext3.  This needs some
> > merge fix ... (and will probably currently cause crashes :-()
> 
> Grrr...  Same as changes in the first commit, done to the function introduced
> by the second (i.e. replace mnt->mnt_sb with dentry->d_sb).  Incidentally,

OK, I may apply that fix tomorrow.

> what are reiserfs patches doing in ext3 tree, of all places?

Its also the quota tree?

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature