RE: [PATCH v2 4/6] ath6kl: get rid of AR_DBG_LVL_CHECK()

From: David Laight
Date: Thu Jan 05 2012 - 09:14:46 EST



> We don't need it as debug calls already have a log level and compiler
> should be smart enough to optimise away the code when ath6kl
> debug code is not enabled.

Have you checked?
I think you are assuming that because the called
function collapses, the call will be removed allowing
the loop to be removed.
I suspect this is only true if the function is inlined.
IIRC the normal linkage rules mean that only static
functions are candidates for inlining.

David


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/