Re: iwl3945 didn't survive after s2ram failure

From: Michal Hocko
Date: Fri Jan 06 2012 - 03:49:35 EST


On Thu 05-01-12 11:44:17, Yinghai Lu wrote:
> On Thu, Jan 5, 2012 at 6:19 AM, Michal Hocko <mhocko@xxxxxxx> wrote:
>
> >
> > Looking in the history it seems that 497f16f2 [pci: Fix hotplug of
> > Express Module with pci bridges] might be related. It fixes an issue
> > introduced by bbef98ab [PCI: defer enablement of SRIOV BARS] which is a
> > part of my 3.2.0-rc6-00005-ga36bfdd problematic version. But I do not
> > understand details of the patch so I cannot tell that for 100%.
> > Yinghai Lu, is it possible that I the problem I have seen is somehow
> > related? For reference the thread started at
> > https://lkml.org/lkml/2011/12/27/65
>
> you have one bridge that BIOS does not assign resource to it.
> so kernel will allocate resource to it.
>
> [ 0.331694] pci 0000:00:1c.2: BAR 8: assigned [mem 0x80100000-0x803fffff]
> [ 0.331825] pci 0000:00:1c.2: BAR 9: assigned [mem
> 0x80400000-0x805fffff 64bit pref]
> [ 0.332041] pci 0000:00:1c.2: BAR 7: assigned [io 0x4000-0x4fff]
> [ 0.334271] pci 0000:05:00.0: BAR 0: assigned [mem 0x80100000-0x80100fff]
> [ 0.334455] pci 0000:05:00.0: BAR 0: set to [mem
> 0x80100000-0x80100fff] (PCI address [0x80100000-0x80100fff])
> [ 0.334666] pci 0000:00:1c.2: PCI bridge to [bus 05-05]
> [ 0.334794] pci 0000:00:1c.2: bridge window [io 0x4000-0x4fff]
> [ 0.334926] pci 0000:00:1c.2: bridge window [mem 0x80100000-0x803fffff]
> [ 0.335058] pci 0000:00:1c.2: bridge window [mem
> 0x80400000-0x805fffff 64bit pref]
>
> yes, the commit fix the problem.

Thanks for the confirmation!

>
> in the commit log i already said:
>
> | That should fix regression like BIOS does not assign correct resource to
> | bridge.
>
>
> Thanks
>
> Yinghai Lu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/