Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning messageto include domain id.

From: Keir Fraser
Date: Fri Jan 06 2012 - 10:50:17 EST


On 06/01/2012 15:03, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> wrote:

>> As you're touching this anyway, how about fixing the other minor
>> issues with it too? E.g.
>>
>> dev_err(&dev->dev, "Device appears to be assigned to dom%d!"
>> " Overwriting the ownership, but beware.\n",
>> xen_find_device_domain_owner(dev));
>>
>> (a native English speaker may want to comment the "but beware"
>> part - it reads odd for me).
>
> Hm, lets ask the English speakers. Ian?

The suggested reworking above is an improvement. The "but beware" bit is
fine.

-- keir


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/