Re: [PATCH 4/6] x86: initial support for sta2x11

[Joe Perches]

On Sat, 2012-01-07 at 09:22 +0100, Alessandro Rubini wrote:
> > or __func__
> I don't understand. No size? Or you typoed and meant pr_fmt defined above?

I meant that outputting __func__ (in this case
sta2x11_new_instance) doesn't gain much useful
information and generally isn't necessary.

> >> +	uint32_t v[2]; /* used as a string... */
> > less than pretty.
> Sure. But it's informative. Do you prefer a union?

Not really.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/