Re: [RFC][PATCH 2/2] hwmon: (w83627ehf) Add GPIO port 3 functionality

[Alejandro]

Hi Delvare,

On 14-Jan-12 2:18 PM, Jean Delvare wrote:
> On Fri, 13 Jan 2012 19:39:56 -0600, Alex Rio wrote:
> > The w83627ehf chip has 5 GPIO ports, currently none of them is supported.
> > This patch adds the GPIO port 3 driver with the following functions:
> > set/get pin values, direction_in/out, set_debounce.
> > The values are also available to the userspace (if requiered)
> > in the path /sys/class/gpio by using the export/unexport functions.
> > Please look at the REVISIT comment, this is the main reason of the RFC,
> > suggestions will be highly appreciated.
> >
> > Signed-off-by: Alex Rio<scasbyte@xxxxxxxxx>
> > ---
> >   drivers/hwmon/w83627ehf.c |  188 +++++++++++++++++++++++++++++++++++++++++++++
> >   1 files changed, 188 insertions(+), 0 deletions(-)
>
> This is calling for a MFD driver for these chips. This was proposed in
> the past, BTW, but never followed up:
> http://lists.lm-sensors.org/pipermail/lm-sensors/2010-February/027795.html
>
> Putting everything in the current driver is not going to be accepted.
> It certainly looks pleasant because it's a more simple approach, but
> the result would be a complex and unmaintainable driver.

The patch looks great, and it is definitely more maintainable. I'll 
create a patch for the w83627ehf driver and send it as soon as possible. 
Should I make the patch for the w83627hf or wait for Rodolfo???

BR, Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/