Re: [patch v1, kernel version 3.2.1] net/ipv4/ip_gre: Ethernetmultipoint GRE over IP

[Štefan Gula]

DÅa 16. januÃra 2012 15:25, Eric Dumazet <eric.dumazet@xxxxxxxxx> napÃsal/a:
> Le lundi 16 janvier 2012 Ã 15:05 +0100, Åtefan Gula a Ãcrit :
>> DÅa 16. januÃra 2012 14:19, Eric Dumazet <eric.dumazet@xxxxxxxxx> napÃsal/a:
>
>> > Unfortunately you call ipgre_tap_bridge_get() from
>> > ipgre_tap_bridge_get_raddr() but you dont release the refcount on
>> > use_count. Leak in ipgre_tunnel_xmit()
>> >
>> >
>> >> +__be32 ipgre_tap_bridge_get_raddr(struct ip_tunnel *tunnel,
>> >> + Â Â const unsigned char *addr)
>> >> +{
>> >> + Â Â struct ipgre_tap_bridge_entry *entry;
>> >> + Â Â entry = ipgre_tap_bridge_get(tunnel, addr);
>> >
>> > Â Â Â ÂSo maybe you want __ipgre_tap_bridge_get(tunnel, addr); here ?
>> >
>> Hmmm.. I am sorry, I am maybe not that expert on C coding, as most of
>> the codes were copied from linux bridge code. Can you give me a hint
>> how should I change that?
>
> I dont see in net/bridge the code you copied.
>
> Could you give more information ?
>
>

File: net/birdge/br_fdb.c
Functions:
__br_fdb_get
br_fdb_get
My analogy fuctions:
__ipgre_tap_bridge_get
ipgre_tap_bridge_get

-- 
Stefan Gula
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/