Re: [PATCH v2 1/4] Add PR_{GET,SET}_NO_NEW_PRIVS to prevent execvefrom granting privs

From: Andy Lutomirski
Date: Mon Jan 16 2012 - 15:16:09 EST


On Mon, Jan 16, 2012 at 9:33 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> On 01/15, Andy Lutomirski wrote:
>>
>> --- a/kernel/fork.c
>> +++ b/kernel/fork.c
>> @@ -1117,6 +1117,8 @@ static struct task_struct *copy_process(unsigned long clone_flags,
>>       if (retval < 0)
>>               goto bad_fork_free;
>>
>> +     p->no_new_privs = current->no_new_privs;
>
> Again, this is unneeded, ->no_new_privs was copied by dup_task_struct().

Yeah, sorry. Will fix in v3.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/