Re: [git patches] libata updates for 3.3

From: Matthew Garrett
Date: Mon Jan 16 2012 - 19:18:20 EST


On Mon, Jan 16, 2012 at 04:02:31PM -0800, Linus Torvalds wrote:
> On Mon, Jan 16, 2012 at 3:54 PM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> >> Part of the problem with force-enable is that the MMIO BAR may need a
> >> value, and not have it.  That, and an expectations mismatch between BIOS
> >
> > That's fine - we can happily assign one at boot time.
>
> Actually, I think the reason that Matthews patch doesn't work for me
> is that on my device, BAR #5 really is a _port_ BAR.
>
> I didn't play with it much - busy merging and looking at various other
> issues - but I'm starting to wonder whether maybe that 8086:1c01 chip
> doesn't support AHCI at all. Or maybe it does something differently.
>
> Other reports of this have BAR#5 either clear, or an MMIO BAR. That
>
> Region 5: I/O ports at ffe0 [size=16]
>
> looks really odd. Matthew's patch uses
>
> pci_assign_resource(pdev, 5);
>
> but if it is a PIO region, that won't help anything..

More recent ICHs may need different setup here. The datasheet should
have enough to figure it out, but I can take a look once I get back from
LCA.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/