Re: [PATCH 1/2] gpio-pch: cleanup __iomem annotation usage

[Németh Márton]

Hi Linux,

Linus Walleij wrote:
> 2012/1/15 Németh Márton <nm127@xxxxxxxxxxx>:
> 
>> From: Márton Németh <nm127@xxxxxxxxxxx>
>>
>> The __iomem annotation is to be used together with pointers used
>> as iowrite32() parameter. For more details see [1] and [2].
> (...)
>> -       u32 *im_reg;
>> +       u32 __iomem *im_reg;
> 
> Does it work to just say void __iomem *im_reg?
> 
> We usually don't type addresses.

You are right, the correct one should be "void __iomem *im_reg;" .

Should I resend a patch for this?

	Márton Németh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/