Re: [RFC] fs, proc: Introduce /proc/<pid>/task/<tid>/childrenentry v6

[Oleg Nesterov]

On 01/17, Cyrill Gorcunov wrote:
>
> On Tue, Jan 17, 2012 at 06:40:49PM +0100, Oleg Nesterov wrote:
> ...
> > > >
> > > > But this is not enough. exit_ptrace() can do list_move() without
> > > > changing ->real_parent.
> > > >
> > > > I'll try to think. At first glance we can rely on EXIT_DEAD, but
> > > > I'd like to avoid this, I think EXIT_DEAD should die.
> > >
> > > Ouch! Thanks for catching this Oleg. I'll try to come with something
> > > to show as well.
> >
> > Do you see another approach? I don't, so I'd suggest to check
> > "task->exit_state != EXIT_DEAD" instead of !list_empty().
> >
>
> Well, I thought what if I can find another way without EXIT_DEAD
> but seems there is no luck.

Oooooh. Cyrill, it seems I managed to confuse you. And myself.

exit_ptrace() doesn't use ->sibling, it uses ->ptrace_entry!.

Sorry!

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/