Re: PATCH] use void __iomem * pointers for ioread32()/iowrite32()
From: Al Viro
Date: Wed Jan 18 2012 - 01:18:25 EST
On Wed, Jan 18, 2012 at 07:05:18AM +0100, N?meth M?rton wrote:
> From: M?rton N?meth <nm127@xxxxxxxxxxx>
>
> The address pointer of ioread32()/iowrite32() functions are
> of type "void __iomem *". Use matching variable type.
> diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> index 68fa55e..84b7f28 100644
> --- a/drivers/gpio/gpio-pch.c
> +++ b/drivers/gpio/gpio-pch.c
> @@ -231,7 +231,7 @@ static void pch_gpio_setup(struct pch_gpio *chip)
> static int pch_irq_type(struct irq_data *d, unsigned int type)
> {
> u32 im;
> - u32 __iomem *im_reg;
> + void __iomem *im_reg;
NAK. Please, learn what "function with pointer to (possibly qualified) void"
means. It's fairly basic C, so any (post-K&R) textbook would do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/